else { if } makes no sense

I complained about this in gerrit but looks like my
comment was not saved

Change-Id: Ie570bdaf89e93628de730102587064ee0495fb1b

diff --git a/includes/db/Database.php b/includes/db/Database.php
index c082cc9..0a51f49 100644 (file)
--- a/includes/db/Database.php
+++ b/includes/db/Database.php
@@ -2925,11 +2925,9 @@ abstract class DatabaseBase implements DatabaseType {
                                //    started and comitted.
                                wfWarn( "$fname: Transaction already in progress (from {$this->mTrxFname}), " .
                                        " performing implicit commit!" );
-                       } else {
-                               if ( $wgDebugDBTransactions ) {
-                                       wfDebug( "$fname: Transaction already in progress (from {$this->mTrxFname}), " .
-                                               " performing implicit commit!\n" );
-                               }
+                       } elseif ( $wgDebugDBTransactions ) {
+                               wfDebug( "$fname: Transaction already in progress (from {$this->mTrxFname}), " .
+                                       " performing implicit commit!\n" );
                        }
 
                        $this->doCommit( $fname );